Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trigger node delay to be overridden with msg.delay #2707

Merged
merged 2 commits into from Sep 29, 2020

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

Proposed changes

Allow the delay between first and second messages sent by Trigger node to be set per-message using msg.delay.

This does not apply to the looping mode.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Copy link
Member

@dceejay dceejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as implemented. Tests cover single topic use case - should they be extended to include per topic case ?
Happy to merge either way.

@dceejay
Copy link
Member

dceejay commented Sep 28, 2020

@kazuhitoyokoi - are you able to add a translation for packages/node_modules/@node-red/nodes/locales/en-US/messages.json line 323 ? And maybe the .info part of the .html file also ?
Many thanks

@knolleary
Copy link
Member Author

I've updated it to also support overriding the loop interval. Look okay to you @dceejay ?

@dceejay
Copy link
Member

dceejay commented Sep 29, 2020

Works great. Feel free to merge

@knolleary knolleary merged commit 59adf82 into dev Sep 29, 2020
@kazuhitoyokoi
Copy link
Member

@dceejay I will submit Japanese translations for the trigger node tomorrow.

@dceejay dceejay deleted the trigger-delay-override branch September 30, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants