Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected line break of sidebar tab name popover #2716

Merged
merged 1 commit into from Oct 7, 2020
Merged

Fix unexpected line break of sidebar tab name popover #2716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/node_modules/@node-red/editor-client/src/js/ui/common/popover.js
View file
Open in desktop
Expand Up @@ -84,6 +84,7 @@ RED.popover = (function() {
var targetHeight = target.outerHeight();
var divHeight = div.height();
var divWidth = div.width();
var paddingRight = 10;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does fix the one scenario you've highlighted, but I suspect similar issues will exist in all of the different orientations the popover could be used.

An alternative approach would be to use div.outerWidth() and div.outerHeight() in the lines above, so that the padding is accounted for there. But that would then require the deltaSizes magic numbers to be changed as they exist to counter-act padding.

To do this properly will require creating some tests (manual, not automated) that properly verify all of the different pieces of logic. I did have something for that when I wrote this code, but I can't find it now.

So on balance, I'm happy to merge this fix as-is for the given scenario as its the only known instance where the tooltip breaks.

Just noting for the future - some reworking will be need to get rid of the hardcoded numbers.


var viewportTop = $(window).scrollTop();
var viewportLeft = $(window).scrollLeft();
Expand All @@ -105,7 +106,7 @@ RED.popover = (function() {
d = "right";
top = targetPos.top+targetHeight/2-divHeight/2-deltaSizes[size].top;
left = targetPos.left+targetWidth+deltaSizes[size].leftRight;
} else if (left+divWidth > viewportRight) {
} else if (left+divWidth+paddingRight > viewportRight) {
d = "left";
top = targetPos.top+targetHeight/2-divHeight/2-deltaSizes[size].top;
left = targetPos.left-deltaSizes[size].leftLeft-divWidth;
Expand Down