New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging API support in Split/Join nodes #2750

Merged

knolleary merged 1 commit into node-red:dev from node-red-hitachi:split-join-node-mapi

Dec 7, 2020

Contributor

k-toumura commented Nov 4, 2020

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Update Split/Join nodes so that you can capture completion event of the node.

done() for receiving message is deferred until the message is joined and sent to next node.
if buffer overflow is occurred while message is accumulating, done(error) is called only for last message, and done() is called for other messages in buffer to prevent flood of error messages.

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Messaging API support in Split/Join nodes

407cb3e

knolleary merged commit 0a6c08e into node-red:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment