New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging API support in Trigger node #2751

Merged

knolleary merged 1 commit into node-red:dev from node-red-hitachi:trigger-node-mapi

Dec 7, 2020

Contributor

k-toumura commented Nov 5, 2020

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Update Trigger node so that you can capture completion event of the node.

It calls done when the message has been received and:
- the 'first' message has been sent,
- any timer has been set up for the second message
But it does not wait for the second message to be sent before calling done.
(from discussion in Messaging API support of core nodes #2402 (comment))

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          Messaging API support in Trigger node

f038069

knolleary merged commit f5fcf23 into node-red:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment