Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated/added DE translations of security term #2803

Closed
wants to merge 6 commits into from

Conversation

heikokue
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

updated/added german transalations of security term in editor-client/locales/de/editor.json

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Dec 29, 2020

Coverage Status

Coverage remained the same at 69.392% when pulling 6aa95ee on heikokue:i18n-de/security into 9b1c114 on node-red:dev.

@dceejay
Copy link
Member

dceejay commented Dec 29, 2020

Thanks for raising all these PR - I can see the discussion is getting lively and hopefully productive.
Are you able to sign/click the CLA such that we are able to merge them as and when they come to a consensus ?

@heikokue
Copy link
Contributor Author

heikokue commented Dec 29, 2020

Are you able to sign/click the CLA such that we are able to merge them as and when they come to a consensus ?

I already did it some days ago.

@dceejay
Copy link
Member

dceejay commented Dec 29, 2020

Maybe you used a different user id ?

@heikokue
Copy link
Contributor Author

Maybe you used a different user id ?

grafik

@heikokue
Copy link
Contributor Author

the user id is correct, but the email is different.
I added my other address to github settings and hope that works......

@heikokue heikokue changed the title updated/added german transalations of security term in editor-client/locales/de/editor.json updated/added DE transalations of security term Dec 29, 2020
@heikokue heikokue changed the title updated/added DE transalations of security term updated/added DE translations of security term Dec 29, 2020
@heikokue
Copy link
Contributor Author

merged into #2806

@heikokue heikokue closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants