Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview to Export Dialog #2820

Merged
merged 1 commit into from Jan 18, 2021
Merged

Add preview to Export Dialog #2820

merged 1 commit into from Jan 18, 2021

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

Proposed changes

Adds a preview list of the nodes/flows/subflows that will be exported to the Export Dialog.

image

The new tabbed view has the preview as the default view, but the underlying JSON can be viewed by clicking the JSON tab.

The rationale for not showing the JSON by default is that the preview list will give the user confidence over what they are about to export - there is no particular need to see the JSON.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.571% when pulling b1df6d5 on export-preview into c40412d on dev.

@dceejay
Copy link
Member

dceejay commented Jan 12, 2021

Does the json default to compact (useful for cut/paste into forum etc) - or pretty (useful for change control etc)

@knolleary
Copy link
Member Author

It defaults, just as it always has, to the flowFilePretty setting.

If that setting is not set, it defaults to compact.

@knolleary knolleary merged commit bebebaa into dev Jan 18, 2021
@knolleary knolleary deleted the export-preview branch January 18, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants