Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix join node array index and reset #2869

Merged
merged 1 commit into from Feb 25, 2021

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Feb 9, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

this PR allows joining incoming messages into an array
a) in manual mode if msg.parts is there then the index is now honoured - so if two array parts arrive with same index the later will replace the former - and not increase the number of parts arrived - ie you need a complete set on indices in order to complete the array.
b) in auto mode - if you send a msg.reset - but without any msg.parts set - it will now reset all inflight messages rather than complaining about missing parts.

to close #2866

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@dceejay dceejay closed this Feb 9, 2021
@dceejay dceejay reopened this Feb 9, 2021
@dceejay dceejay changed the base branch from master to dev February 9, 2021 17:28
@knolleary knolleary merged commit e6f1394 into dev Feb 25, 2021
@knolleary knolleary deleted the Fix-join-node-array-index-and-reset branch February 25, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join node not reset when operating in automatic mode
2 participants