Fix join node array index and reset #2869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this PR allows joining incoming messages into an array
a) in manual mode if msg.parts is there then the index is now honoured - so if two array parts arrive with same index the later will replace the former - and not increase the number of parts arrived - ie you need a complete set on indices in order to complete the array.
b) in auto mode - if you send a msg.reset - but without any msg.parts set - it will now reset all inflight messages rather than complaining about missing parts.
to close #2866
Checklist
grunt
to verify the unit tests pass