Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy of node in group #2872

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Fix deploy of node in group #2872

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1be337f
make nodes with only group change not deployed by nodes deploy mode
HiroyasuNishiyama Feb 12, 2021
b66468c
restart node only if node's group changes
HiroyasuNishiyama Feb 14, 2021
12c7238
revert diffConfigs args
HiroyasuNishiyama Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/node_modules/@node-red/runtime/lib/flows/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,21 @@ module.exports = {
// This node has a property that references a changed/removed node
// Assume it is a config node change and mark this node as
// changed.
if (changed[node[prop]] || removed[node[prop]]) {

var changeOrigin = changed[node[prop]];
if (changeOrigin || removed[node[prop]]) {
if (!changed[node.id]) {
if (changeOrigin &&
(prop === "g") &&
(changeOrigin.type === "group")) {
var oldNode = oldConfig.allNodes[node.id];
// ignore change of group node
// if group of this node not changed
if (oldNode &&
(node.g === oldNode.g)) {
continue;
}
}
madeChange = true;
changed[node.id] = node;
// This node exists within subflow template
Expand Down