Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New attempt for PR #2821 #2879

Merged
merged 1 commit into from Feb 22, 2021
Merged

Conversation

HaKr
Copy link
Contributor

@HaKr HaKr commented Feb 19, 2021

PR #2821 could not be completed due to different email addresses used for it's commits.
This new branch is meant to be used as a new PR to replace the failed one

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

The palette editor only checks the first three numbers of a module version. When using pre-release additions, the editor does not correctly shows updated modules.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

PR node-red#2821 could not be completed due to different email addresses used for it's commits.
This new branch is meant to be used as a new PR to replace the failed one
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.385% when pulling 02dd141 on HaKr:SemVerFullCompareNewAttempt into 7d04353 on node-red:master.

@knolleary knolleary merged commit 69befe8 into node-red:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants