fix flowfile name to flows.json in settings #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and warn if not set (as if anyone reads warnings) Move setting to top of settings.js as it will be edited more often. Default behaviour will still work (needs translations)
knolleary
reviewed
Apr 23, 2021
packages/node_modules/@node-red/runtime/locales/en-US/runtime.json
Outdated
Show resolved
Hide resolved
…json Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR presets the flow file name to flows.json in the settings.js file - thus it will only apply to new installs unless people update their settings file. It also adds a warning if it is not set - so say that the hostname is being used.
This should make things more obvious for people moving flows from one machine to another in that the flow should just work without having to be renamed. Will also make running on some other platforms (like docker) easier as then the default settings can be used.
Checklist
gruntto verify the unit tests pass