Deprecate usage of httpRoot and add warning #2953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(no change is actual behaviour yet - just warning)
Should we remove option from settings ? or just label it ?
Proposed changes
This PR - deprecates the usage of httpRoot in settings .js - having overlapping options can cause confusion - Cleaner just to be explicit about httpNodeRoot and httpAdminRoot. This PR only adds a warning - and does not actually change functionality yet.
Checklist
grunt
to verify the unit tests pass