Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order inject typedinput to de-emphasise context options #2961

Merged
merged 2 commits into from Apr 28, 2021

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Apr 27, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

This just reorganises the typedinput list to move the context options to the bottom of the list to de-emphasise them - in particular msg. that has no real meaning here as there is no msg (though it could be used to duplicate a previous entry I suppose) - see https://github.com/orgs/node-red/projects/8#card-56046423

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Apr 27, 2021

Coverage Status

Coverage increased (+0.03%) to 67.7% when pulling 19d391f on rerorder-inject-typedinput into 4133f9c on dev.

@knolleary
Copy link
Member

I would like to keep the order of the list as consistent as possible with all of the other TypedInputs that offer these options. In this instance, I don't mind moving msg to the bottom, but I disagree with moving flow and global. Being able to inject the current value of a context value is entirely valid and useful. I see no reason to de-emphasise their use.

@dceejay
Copy link
Member Author

dceejay commented Apr 27, 2021

Yes - I just thought once we moved msg it made sense to keep them together as a sub-group - all items on the list are valid. I just think string, number etc are the most used.

@knolleary
Copy link
Member

Given the default value is str then I don't see any real issue with keeping flow/global at the top of the list where they appear everywhere else.

@knolleary knolleary added the 2.0 label Apr 28, 2021
@knolleary knolleary added this to In progress in Node-RED 2.0 Planning Apr 28, 2021
@knolleary knolleary merged commit 1d4dd4b into dev Apr 28, 2021
Node-RED 2.0 Planning automation moved this from In progress to Done Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants