Change node id generation to give fixed length values without '.' #2987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR changes the algorithm used to generate ids in the editor and runtime.
The existing code could produce variable length ids and had a
.
in the middle - which was accidental rather than intentional because all those years ago, I forgot to includeMath.floor()
in the code. egbfc71766.923608
The new algorithm creates 8-byte fixed length ids without the
.
- eg4ab59dd6503989b6
. This gives us a range of 2^64 − 1 values - which is suitably random to avoid collisions within individual NR instances.