Get got - deactivate HTTP - Proxy unit tests #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been removed because the mock proxy doesn't support using the HTTP CONNECT verb and the new Got based http-request node only uses CONNET for proxied content
|
This looks like it might do as a replacement for the mock proxy for at least some of the existing tests https://github.com/TooTallNate/proxy Will see how many I can redo with this. |
This end point is currently not hit
Down to only 2 of the previous tests not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the HTTP Proxy tests until they can be rewritten to use a proxy that supports the HTTP Connect verb.
Checklist
gruntto verify the unit tests pass(err...)