Restructure default settings.js to be more organised #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceejay
reviewed
Jun 8, 2021
| ******************************************************************************/ | ||
|
|
||
| // Uncomment the following to run node-red in your preferred language: | ||
| // lang: "de", |
There was a problem hiding this comment.
should we mention which languages we have translations for ? (and maybe encourage contributions... ?)
Makes clearer what is a comment and what is commented-out code.
|
Update pushed to change the comment style to make it clearer what is a comment and what is a commented-out setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of settings has inevitably grown over time and they have become a bit of a muddle. This PR attempts to fix that.
The settings are have been reordered into clearly labelled sections:
I have removed
paletteCategoriesas that was deprecated some time ago and should beeditorTheme.palette.categories- the code has handled both for some time now. The docs need to be updated to match.The diff provided by this PR doesn't necessarily make it easy to appreciate the overall structure of the new file. You can see the new file in its entirety here: https://github.com/node-red/node-red/blob/reorganise-settings/packages/node_modules/node-red/settings.js