Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for basic auth with @ in username #3017

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Fix for basic auth with @ in username #3017

merged 3 commits into from
Jun 11, 2021

Conversation

hardillb
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Manually build the Authentication header to work round URL encoding problem

Also add support for user/password in URL e.g.

http://user:pass@www.example.com

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit ac159bb into node-red:dev Jun 11, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 67.525% when pulling 919aee6 on hardillb:dev into 4acb66f on node-red:dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants