exec node: add windowsHide option #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceejay
reviewed
Jun 18, 2021
| @@ -80,4 +80,5 @@ <h4>Killing processes</h4> | |||
| <p>If the node has more than one process running then <code>msg.pid</code> must also be set with the value of the PID to be killed.</p> | |||
| <p>If a value is provided in the <code>Timeout</code> field then, if the process has not completed when the specified number of seconds has elapsed, the process will be killed automatically</p> | |||
| <p>Tip: if running a Python app you may need to use the <code>-u</code> parameter to stop the output being buffered.</p> | |||
| <p>The <code>Hide windows</code> option can be set to hide shell windows under Windows.</p> | |||
There was a problem hiding this comment.
should we emphasis that this ONLY has an effect under Windows ? or does it do something under Linux/Mac also ?
|
May just need to make clear this an option for Windows only - and check it doesn't do bad things if set on other OS. - but yes looks good. |
|
Hi Dave, just added a clarification, let me know if it suits you ! |
|
Tested on my windows PC, works well! Thanks! Looking forward this merge! |
|
All good with me. @knolleary happy for you to merge for v2 |
|
Thanks for this. Will merge, but am going to modify the wording slightly... says "Windows" a few too many times in a single sentence :) |
|
Summary of changes:
|
|
Thanks !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds a
Hide windowscheckbox to the exec node to allow hiding shell windows under windows. Without this, the windowsHide option of exec and spawn defaults to false and shell windows will appear briefly when running commands.Checklist
gruntto verify the unit tests pass