Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Monaco Editor to V0.25.2 (latest) #3031

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Jun 24, 2021

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Update Monaco Editor to V0.25.2 (latest)

Additionally, with 0.25.2 the unhandled Canceled promise rejection on mousemove event is no longer an issue so the temporary global window hander for this rejection has been removed from monaco.js.

Lastly, an issue with a promise rejection upon opening function node editor UI was noted and fixed in this update.

NOTE
When running grunt, I had to install nyc

Running "nyc:all" (nyc) task
'nyc' is not recognized as an internal or external command,
operable program or batch file.
Fatal error: spawn nyc ENOENT

Should nyc be in the devDependancies? or is this something you have installed globally?

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 56df8d8 into node-red:dev Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants