Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output label in file-in node #3039

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Fix output label in file-in node #3039

merged 2 commits into from
Jun 29, 2021

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

In the Japanese environment, I found that there is "s" in the output labels of the file-in node.

image

This problem is caused by a hardcode to describe plural words in the English environment. To solve the problem, I added new entries for plural words to be the same as other entries to distinguish singular and plural words.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 1a81794 into node-red:dev Jun 29, 2021
@kazuhitoyokoi
Copy link
Member Author

@knolleary Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants