Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fs-extra module to dependencies in @node-red/util module #3052

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Add fs-extra module to dependencies in @node-red/util module #3052

merged 1 commit into from
Jul 8, 2021

Conversation

kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

When I tried the electron Node-RED using Node-RED v2.0 beta 2, I encountered a startup error.

I found that this problem came from a lack of dependencies in the @node-red/util module. Therefore, I added the fs-extra module as dependencies in the @node-red/util module. (Strangely, this problem didn't occur using Node-RED v1.3.5).

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.604% when pulling e81a6db on kazuhitoyokoi:dev-fixdependencies into b2f5a25 on node-red:dev.

@knolleary
Copy link
Member

This needs fixing in master as well.

@knolleary knolleary merged commit 94891d4 into node-red:dev Jul 8, 2021
@kazuhitoyokoi
Copy link
Member Author

kazuhitoyokoi commented Jul 8, 2021

@knolleary Thank you for the fixing in the master branch. :)

@kazuhitoyokoi
Copy link
Member Author

@knolleary For dev and master branches, I submitted other pull requests related to this. Could you check them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants