Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add align actions to editor #3110

Merged
merged 9 commits into from
Sep 7, 2021
Merged

Add align actions to editor #3110

merged 9 commits into from
Sep 7, 2021

Conversation

knolleary
Copy link
Member

@knolleary knolleary commented Aug 16, 2021

  • New feature (non-breaking change which adds functionality)

Proposed changes

Adds align actions to the editor:

  • core:align-selection-to-left - alt-a l
  • core:align-selection-to-center - alt-a c
  • core:align-selection-to-right - alt-a r
  • core:align-selection-to-top - alt-a t
  • core:align-selection-to-middle - alt-a m
  • core:align-selection-to-bottom - alt-a b
  • core:distribute-selection-horizontally - alt-a h
  • core:distribute-selection-vertically - alt-a v

ToDo:

  • Consider if align-selection-to-group should apply to nodes inside groups - it doesn't currently
  • Add actions to distribute horizontally/vertically
  • Add align menu to main menu

https://trello.com/c/iYmbLYT1

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Aug 16, 2021

Coverage Status

Coverage decreased (-0.02%) to 67.637% when pulling 192b542 on view-tools into f1e7ec0 on dev.

@knolleary
Copy link
Member Author

Final update - have added menu options to for these actions, along with some other common actions.

Also updated the menu to display keyboard shortcuts against menu items if one is set.

@knolleary knolleary merged commit 9a4dc30 into dev Sep 7, 2021
@knolleary knolleary deleted the view-tools branch September 7, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants