Fixes to fs promises so that an electron built version runs #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
|
|
|
/easycla |
knolleary
reviewed
Sep 24, 2021
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This replaces fs-extra with fs and uses the fs.promises versions for the async calls
This fixes the issue that causes electron to fail to run complaining about Unhandled promise rejection.
In draft as tests now fail... need to discuss if it's the tests that need fixing or the code...
Checklist
gruntto verify the unit tests pass