Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting with oauth login strategies #3148

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Conversation

knolleary
Copy link
Member

Proposed changes

Previously, if there was a problem with logging in using a Passport strategy (rather than username/password), there were two possible results:

  1. the page reloads to show the login dialog with no visible feedback there was an issue
  2. a blank page containing a stack trace from the internals of Passport

With this PR, we now always redirect back to the login dialog and also provide feedback that the login failed. The feedback will be the error description returned by the passport strategy. In the case of Oauth, that'll be the error_description field in the oauth response.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit 5ec3544 into dev Sep 24, 2021
@knolleary knolleary deleted the login-fixes branch September 24, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant