Improve error reporting with oauth login strategies #3148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, if there was a problem with logging in using a Passport strategy (rather than username/password), there were two possible results:
With this PR, we now always redirect back to the login dialog and also provide feedback that the login failed. The feedback will be the error description returned by the passport strategy. In the case of Oauth, that'll be the error_description field in the oauth response.
Checklist
grunt
to verify the unit tests pass