Improve themeing of tourGuide #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted here the Tour theme doesn't work well on dark themes that have not been rebuilt for 2.1.
Whilst the tour component is theme-aware, some restructuring on how the popover component applies its style means existing styles won't quite do the right thing until they get rebuilt for 2.1.
I've no doubt themes will get updated and rebuilt for 2.1, but if a user updates NR to 2.1 without updating their theme as well, then they will be greeted with the new welcome tour not looking good.
This PR tweeks how the styles are applied so they look semi-decent on dark themes that haven't bene rebuilt for 2.1.