Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay node: add option to send intermediate messages on separate output #3166

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

knolleary
Copy link
Member

  • New feature (non-breaking change which adds functionality)

Proposed changes

Backlog item: https://trello.com/c/1jAoRESp

This changes the 'drop intermediate messages' checkbox of the Delay node (in rate limit mode) to a select box. The options are:

  • Queue intermediate messages - the default behaviour, equivalent to the old checkbox being unticked
  • Drop intermediate messages - equiv to the old checkbox being ticked
  • Send intermediate messages on 2nd output.

If this last option is selected, the node gains a 2nd output. Any message that would previously have been dropped will now get sent on that output.

This is useful for rate limiting flows that need to do some work with the 'reject' messages. For example, rate limiting an HTTP API, where the 'dropped' requests need to be responded to with a 503.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary requested a review from dceejay October 4, 2021 12:04
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 67.681% when pulling 1c18641 on output-discarded-rate-limit into 1419729 on dev.

@knolleary knolleary merged commit 4adad6e into dev Oct 6, 2021
@knolleary knolleary deleted the output-discarded-rate-limit branch October 6, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants