Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add string option to TCP request node output #3204

Merged
merged 2 commits into from
Oct 20, 2021
Merged

Add string option to TCP request node output #3204

merged 2 commits into from
Oct 20, 2021

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Oct 19, 2021 •
edited

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

adds an option to select a string type output to the TCP request node. (The TCP In node already has it)
Defaults to Buffer as per existing.
image

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 19, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@dceejay dceejay changed the base branch from master to dev October 19, 2021 20:39
@dceejay
Copy link
Member Author

dceejay commented Oct 19, 2021

/easycla

@coveralls
Copy link

coveralls commented Oct 19, 2021 •
edited

Coverage Status

Coverage decreased (-0.02%) to 67.394% when pulling a7413cc on tcp-req-text-output into 8d79def on dev.

@knolleary knolleary merged commit fc9d65a into dev Oct 20, 2021
@knolleary knolleary deleted the tcp-req-text-output branch October 20, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dceejay @coveralls @knolleary