Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved regex for markdown renderer #3213

Merged
merged 1 commit into from
Oct 24, 2021

Conversation

GerwinvBeek
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

After the recent changes it was not possible anymore to use images in node-red markdown. The renderer would put a space between : and // when using markdown urls like ![](https://url.png).

With this change the image will render like it is supposed to.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 67.394% when pulling 836f7d2 on GerwinvBeek:markdown-regex into d4d6f71 on node-red:master.

@knolleary
Copy link
Member

Looks good - well spotted.

@knolleary knolleary merged commit 35f617e into node-red:master Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants