Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to enable/disable tours #3221

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

hardillb
Copy link
Member

@hardillb hardillb commented Oct 25, 2021

NODE_RED_ENABLE_TOURS

Also had to patch editor-api/lib/editor/themes.js to pass
editorTheme.tours to the editor.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Ticked both, because Env Var is new, but needed to fix not passing editorTheme.tours to the browser side.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

NODE_RED_ENABLE_TOURS

Also had to patch editor-api/lib/editor/themes.js to pass
`editorTheme.tours` to the editor.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 67.372% when pulling 2e7188e on hardillb:disable-tours into 5a01218 on node-red:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants