Fix loading non-default language files leaving runtime in wrong locale #3225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discourse.nodered.org/t/2-0-6-shows-different-node-errors-in-different-languages/51693
In some rare occasions, the runtime was randomly emitting log messages in the wrong locale.
This could happen if someone requests a message catalog in the a non-default locale (eg http://localhost:1880/locales/node-red?lng=ja). The slightly hacky way these requests were handled, meant the i18n subsystem was switched to the desired language, the catalog loaded, then switched back to the primary runtime language.
However the restore of the language was happening in parallel which could leave it in an inconsistent state.
This improves the sequencing to reduce the chances of this happening. However the overall logic is not ideal and we do need a way to load non-default catalogues without modifying the current default.