Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select menu label of config node to use paletteLabel #3273

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Currently, config node is shown using node type in config node selection menu ((1) in the following figure). But, the config node is shown using paletteLabel name in settings panel ((2) in the following figure).

This difference seems ambiguous, so this PR change them to use the same paletteLabel expression.

スクリーンショット 2021-11-24 14 18 19

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 67.396% when pulling 711467a on node-red-hitachi:fix-config-select-name into 9439cd0 on node-red:master.

@knolleary knolleary merged commit 682dff7 into node-red:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants