New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix removed tab not to cause node conflict #3275

Merged

knolleary merged 1 commit into node-red:master from node-red-hitachi:fix-node-conflict

Dec 1, 2021

Member

HiroyasuNishiyama commented Nov 25, 2021

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Following editor operation causes node conflict on importing flow:

detele flow tab,
import a flow with nodes that was contained in the flow tab of (1)

This is because the tab information is deleted too early, so the deletion is delayed in this PR.

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          fix removed tab not to cause node conflict

1f0690c

coveralls commented Nov 25, 2021

Coverage increased (+0.05%) to 67.363% when pulling 1f0690c on node-red-hitachi:fix-node-conflict into 9439cd0 on node-red:master.

knolleary merged commit 85415eb into node-red:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment