Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load extralibs when expanding monaco. fixes #3319 #3334

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

Steve-Mcl
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Ensure extra libs are declared in monaco to prevent red error underline on libraries declared in setup tab.

See issue #3319

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.361% when pulling b5e48aa on Steve-Mcl:fix-monaco-expanded into b14c42b on node-red:master.

@knolleary knolleary merged commit ce98ed9 into node-red:master Jan 10, 2022
@Steve-Mcl Steve-Mcl deleted the fix-monaco-expanded branch January 10, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants