Add log logging #3342
Merged
Add log logging #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knolleary
force-pushed
the
add-log-logging
branch
from
20fff59
to
c801bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds some comprehensive logging if a call to
Node.logitself throws an error.That should not happen - but we have #3327 telling us it can happen. This logging should capture more information about the state of the node and its flow object. It will also tell us the type/id/module of the node that hit the error.
A side-effect of this PR is nodes now have a
_moduleproperty that is information about the module that provided the node - including name and version.Checklist
gruntto verify the unit tests pass