Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize passport when only adminAuth.tokens is set #3343

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Initialize passport when only adminAuth.tokens is set #3343

merged 2 commits into from
Jan 12, 2022

Conversation

knolleary
Copy link
Member

Fixes #3341

If adminAuth only contained tokens then we were not initialising Passport properly.

This fixes that and also adds some trace level logging if the token-auth fails for any reason.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary mentioned this pull request Jan 12, 2022
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 67.354% when pulling ea20342 on adminAuth-logging into f8c47f5 on master.

@knolleary knolleary merged commit 86d518f into master Jan 12, 2022
@knolleary knolleary deleted the adminAuth-logging branch May 3, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdminAuth using token from Cloudflare fails to assign user
2 participants
@knolleary @coveralls