Only setup ws client heartbeat once it is connected #3344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #3264
The WebSocket Client heartbeat interval was being setup before the socket's
open
event fired - meaning it could try to send a ping before the client connected.This fix moves the setup of the heartbeat to the
open
event handler and adds error handling around theping()
call to ensure it can't error if it hits a timing window of triggering whilst the socket is closing.