Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: Dont add wires to undo buffer twice #3437

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

Steve-Mcl
Copy link
Contributor

Fixes #3433

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Proposed changes

wrap the push to removedLinks array to ensure removed links are removed from selectedLinks (to avoid duplicate additions to undo history

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.313% when pulling b3f1401 on Steve-Mcl:fix-multiple-wires into e5e3832 on node-red:master.

@knolleary knolleary merged commit 264047d into node-red:master Feb 14, 2022
@Steve-Mcl Steve-Mcl deleted the fix-multiple-wires branch February 14, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate wires between nodes with 2.2.0
3 participants