Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ESM module loading in Function node #3645

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Fix ESM module loading in Function node #3645

merged 1 commit into from
Jun 13, 2022

Conversation

knolleary
Copy link
Member

Fixes #3627

Uses module.createRequire to properly resolve both CJS and ESM module import paths.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 68.445% when pulling 71a272f on fix-esm into 3e34d0b on master.

@knolleary knolleary merged commit 8cec0d8 into master Jun 13, 2022
@knolleary knolleary deleted the fix-esm branch June 13, 2022 13:10
@Steve-Mcl Steve-Mcl mentioned this pull request Jun 13, 2022
Merged
knolleary added a commit that referenced this pull request Jun 16, 2022
@knolleary
Merge pull request #3662 from Steve-Mcl/backport-3645
3f29283 
Fix ESM module loading in Function node (Backport #3645 to v2.x)
This was referenced Dec 12, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import ESM modules in function nodes
2 participants
@knolleary @coveralls