Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate new node-ids when pasting a cut flow #3729

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

knolleary
Copy link
Member

Fixes #3629

After cutting a flow to the clipboard, we shouldn't generate new ids when it gets pasted. This ensures any nodes that were targeting the cut nodes (link-call, catch etc) still target the nodes after they are pasted.

When pasting a flow that was copied to the clipboard, we still generate ids as before.

This feels a more expected behaviour.

@coveralls
Copy link

coveralls commented Jul 1, 2022

Coverage Status

Coverage increased (+0.004%) to 68.33% when pulling 78ed53f on cut-vs-copy into f760354 on master.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@Steve-Mcl Steve-Mcl merged commit 8cb212d into master Jul 6, 2022
@Steve-Mcl Steve-Mcl deleted the cut-vs-copy branch July 6, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cut-paste a link-in node resets link-call nodes
3 participants