Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of global debug message #3733

Merged

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Global debug message causes editor runtime error.
This PR try to fix the issue.

Steps to reproduce:

  1. Import web socket node example and deploy it,
  2. Delete the imported flow,
  3. Re-Deploy,
  4. (3) causes Error: stopping node: Close timed out,
  5. (4) results in editor runtime error TypeError: Cannot read properties of undefined.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.33% when pulling 67f4553 on node-red-hitachi:fix-debug-message-handling into b2bb656 on node-red:master.

@knolleary knolleary merged commit 8daade0 into node-red:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants