New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close timeout of websocket node #3734

Merged

knolleary merged 1 commit into node-red:master from node-red-hitachi:fix-close-websocket

Jul 4, 2022

Member

HiroyasuNishiyama commented Jul 4, 2022

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Proposed changes

Re-deploying a flow containing web socket node causes Error stopping node: Close timed out.
This PR try to fix the issue.

Steps to reproduce:

Import web socket node example and deploy it,
Delete the imported flow,
Re-Deploy,
(3) causes Error: stopping node: Close timed out,

Checklist

I have read the contribution guidelines
For non-bugfix PRs, I have discussed this change on the forum/slack team.
I have run grunt to verify the unit tests pass
I have added suitable unit tests to cover the new/changed functionality


          call done after close handler

277cc19

coveralls commented Jul 4, 2022

Coverage decreased (-0.004%) to 68.326% when pulling 277cc19 on node-red-hitachi:fix-close-websocket into b2bb656 on node-red:master.

knolleary merged commit 7072265 into node-red:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment