Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't let themes change disabled config node background color #3736

Merged

Conversation

bonanitech
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

While testing the changes from #3730, I noticed that I left disabled config nodes out of #3564.

Screen Shot 2022-07-04 at 4 59 41 PM

This PR fixes that by using the same background color as in the default theme.

Screen Shot 2022-07-04 at 5 03 00 PM

Screen Shot 2022-07-04 at 5 04 03 PM

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

coveralls commented Jul 4, 2022

Coverage Status

Coverage remained the same at 68.328% when pulling 744375b on bonanitech:disabled-config-node-background into 7072265 on node-red:master.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@Steve-Mcl Steve-Mcl merged commit af08c07 into node-red:master Jul 6, 2022
@bonanitech bonanitech deleted the disabled-config-node-background branch July 6, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants