Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move colors left behind in #3692 to CSS variables #3737

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Move colors left behind in #3692 to CSS variables #3737

merged 1 commit into from
Jul 6, 2022

Conversation

bonanitech
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

A few SASS variables were left behind in #3692. This PR fixes that.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.328% when pulling 7d0267c on bonanitech:pr3692-leftovers into 7072265 on node-red:master.

Steve-Mcl
Steve-Mcl approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Steve-Mcl Steve-Mcl merged commit 84e2489 into node-red:master Jul 6, 2022
@bonanitech bonanitech deleted the pr3692-leftovers branch July 6, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bonanitech @coveralls @Steve-Mcl