Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context menu issues ready for v3 beta.5 #3741

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #3739

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Fix insert=>link nodes enable/disable state

Allow escape key to close context menu

Allow editor events to close context menu

code linting and remove excessive new lines

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl changed the title Fix context menu issues ready for v3 beta.4 Fix context menu issues ready for v3 beta.5 Jul 6, 2022
@Steve-Mcl Steve-Mcl added this to the 3.0 milestone Jul 6, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.328% when pulling 7216c6d on Steve-Mcl:fix-context-menu into 8cb212d on node-red:master.

@Steve-Mcl Steve-Mcl requested a review from knolleary July 6, 2022 14:19
@knolleary knolleary merged commit 0682c34 into node-red:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu issues in v3 (beta-5)
3 participants