Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent exception generating tooltip for deleted nodes #3742

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #3740 (Uncaught TypeError error in browser console when deleting nodes from canvas)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Check that node exists inside the timer callback - before attempting to generate a tooltip and calculate offsets etc.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 68.322% when pulling 9626725 on Steve-Mcl:fix-tooltip-exception into 8cb212d on node-red:master.

@knolleary knolleary merged commit 87258e4 into node-red:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError error in browser console when deleting nodes from canvas
3 participants