Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clear pinned paths of debug sidebar menu #3745

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

HiroyasuNishiyama
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Selecting Clear pinned paths of debug sidebar item menu for global message causes editor runtime error.

debug-utils.js:468 Uncaught TypeError: activeMenuMessage.clearPinned is not a function
    at Object.onselect (debug-utils.js:468:43)
    at f (red.min.js?v=3.0.0-beta.4:18:47386)
    at HTMLAnchorElement.<anonymous> (red.min.js?v=3.0.0-beta.4:18:46029)
    at HTMLAnchorElement.dispatch (vendor.js?v=3.0.0-beta.4:2:43090)
    at v.handle (vendor.js?v=3.0.0-beta.4:2:41074)

This PR try to fix the issue.

スクリーンショット 2022-07-08 13 13 43

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 68.311% when pulling 5ae5669 on node-red-hitachi:fix-debug-path-menu into 8cb212d on node-red:master.

@knolleary knolleary merged commit e308e02 into node-red:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants