Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display direction of context sub-menu #3746

Merged
merged 5 commits into from
Jul 8, 2022
Merged

Fix display direction of context sub-menu #3746

merged 5 commits into from
Jul 8, 2022

Conversation

knolleary
Copy link
Member

This PR includes #3744 - adding a fix for the positioning of the menu caret icon for dropdown menus that pull left.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.311% when pulling 241b47f on pr_3744 into e308e02 on master.

@Steve-Mcl
Copy link
Contributor

Hi Nick, do you want me to test this out and submit a review or are you happy to go with it?

@knolleary
Copy link
Member Author

If you can take a quick look, please do. I've manually checked all the different menus in the main editor to check no unexpected side-effects.

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, tested this branch, working good. There is one issue with Insert=>Junction leaving workspace dirty but i don't think it is related (will raise separate issue)

@knolleary knolleary merged commit 62332a2 into master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants