Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure global-config and flow-config have info in the hierarchy popover #3752

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #3750

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Ensure global configs are listed and clickable

Tested with named, unnamed, global/flow config nodes

global config now looks like...

chrome_00lugEGWvy

flow config now looks like...

chrome_2qrqL0dKEN

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested a review from knolleary July 11, 2022 12:15
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.311% when pulling 4421631 on Steve-Mcl:fix-global-path-popover into e14dd06 on node-red:master.

@knolleary knolleary merged commit e3b1f05 into node-red:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial path popover shown in debug when hovering config node message
3 participants