Use theme page and header values if settings.js values are not present #3767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Proposed changes
header
andpage
valuespage
andheader
values ifsettings.js
values are not presentTested...
page.favicon = null
page.favicon = null
page.favicon = null
page.favicon = 'common/favicon.ico'
page.favicon = 'custom-icon.ico'
page.favicon = 'common/favicon.ico'
page.title = null
page.title = null
page.title = null
page.title = 'theme title'
page.title = 'settings.js title'
page.title = 'theme title'
header.image = null
header.image = null
header.image = null
header.image = 'common/image.ico'
header.image = 'custom-icon.ico'
header.image = 'common/image.ico'
header.title = null
header.title = null
header.title = null
header.title = 'theme title'
header.title = 'settings.js title'
header.title = 'theme title'
header.url = null
header.url = null
header.url = null
header.url = 'theme url'
header.url = 'settings.js url'
header.url = 'theme url'
Checklist
grunt
to verify the unit tests pass