Do not flag hasUsers=false nodes as unused in search #3787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3777
Sometimes it is valid to have a config node that is "unused" - such as the
ui_base
node from Dashboard.Such nodes can set a property called
hasUsers
tofalse
in their definition. This stops the Configuration Nodes sidebar from showing them as unused, and for the unused-nodes check to flag them after a deploy.This fix updates the search filter
is:unused
to take the flag in to account.