Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus issues #3789

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Fix focus issues #3789

merged 3 commits into from
Jul 21, 2022

Conversation

Steve-Mcl
Copy link
Contributor

fixes #3783

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

  1. ensure red-ui-editor-stack is focusable

  2. focus stack when re-showing nested editor

  3. focus search input when opened via context menu

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@Steve-Mcl Steve-Mcl requested a review from knolleary July 20, 2022 11:30
@Steve-Mcl Steve-Mcl mentioned this pull request Jul 20, 2022
Open
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 68.218% when pulling 273404e on Steve-Mcl:fix-focus-issues into 1b94cc3 on node-red:master.

@knolleary knolleary merged commit ede82ad into node-red:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary Awaiting requested review from knolleary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

focus issues
3 participants
@Steve-Mcl @coveralls @knolleary